FabInfra-Mirror/libs.capnproto-dotnetcore_Runtime
1
0
Fork 0
mirror of https://github.com/FabInfra/capnproto-dotnetcore_Runtime.git synced 2025-03-13 23:31:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

RpcEngine.RemoveImport should throw rather than just log a warning when import ID is wrong

Browse Source
This commit is contained in:
Christian Köllner 2019-08-23 22:53:49 +02:00
parent c8881f3482
commit 7ea1c5dd1d
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Capnp.Net.Runtime.Tests/TcpRpcInterop.cs
View File

@ -345,7 +345,7 @@ namespace Capnp.Net.Runtime.Tests
})); }));
} }
// Ensure that all answers either return (probably in canceled state) // Ensure that all answers return (probably in canceled state)
Assert.IsTrue(Task.WhenAll(taskList).Wait(LargeNonDbgTimeout)); Assert.IsTrue(Task.WhenAll(taskList).Wait(LargeNonDbgTimeout));
// Not part of original test. "Terminate" sequence with // Not part of original test. "Terminate" sequence with

12
Capnp.Net.Runtime/Rpc/RpcEngine.cs
View File

@ -1453,16 +1453,12 @@ namespace Capnp.Rpc
void IRpcEndpoint.RemoveImport(uint importId) void IRpcEndpoint.RemoveImport(uint importId)
{ {
bool exists;
lock (_reentrancyBlocker) lock (_reentrancyBlocker)
{ {
exists = _importTable.Remove(importId); if (!_importTable.Remove(importId))
} {
throw new ArgumentException("Given ID does not exist in import table");
if (!exists) }
{
Logger.LogError("Inconsistent import table detected");
} }
} }