From 9bb6274a1c3bf732bc9e16e5738264d63c9b1409 Mon Sep 17 00:00:00 2001 From: TheJoKlLa Date: Thu, 2 Feb 2023 22:18:13 +0100 Subject: [PATCH] Improve Randomes --- NFC/Cards/NXP MIFARE DESFire/NXP_MIFARE_DESFire.cs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/NFC/Cards/NXP MIFARE DESFire/NXP_MIFARE_DESFire.cs b/NFC/Cards/NXP MIFARE DESFire/NXP_MIFARE_DESFire.cs index c45af86..8696ca2 100644 --- a/NFC/Cards/NXP MIFARE DESFire/NXP_MIFARE_DESFire.cs +++ b/NFC/Cards/NXP MIFARE DESFire/NXP_MIFARE_DESFire.cs @@ -12,6 +12,7 @@ using Org.BouncyCastle.Crypto.Parameters; using System; using System.Collections.Generic; using System.Linq; +using System.Security.Cryptography; namespace NFC.Cards.NXP_MIFARE_DESFire { @@ -305,9 +306,9 @@ namespace NFC.Cards.NXP_MIFARE_DESFire if (rndA == null) { - Random rnd = new Random(); rndA = new byte[8]; - rnd.NextBytes(rndA); + RNGCryptoServiceProvider cryptoProvider = new RNGCryptoServiceProvider(); + cryptoProvider.GetBytes(rndA); } _Log.DebugFormat("rndA: {0}", HexConverter.ConvertToHexString(rndA)); @@ -458,9 +459,9 @@ namespace NFC.Cards.NXP_MIFARE_DESFire if (rndA == null) { - Random rnd = new Random(); rndA = new byte[16]; - rnd.NextBytes(rndA); + RNGCryptoServiceProvider cryptoProvider = new RNGCryptoServiceProvider(); + cryptoProvider.GetBytes(rndA); } _Log.DebugFormat("rndA: {0}", HexConverter.ConvertToHexString(rndA));