Patched Styles To Layers extension

extensions/fablabchemnitz/styles_to_layers.inx

@@ -20,8 +20,11 @@
     <param name="decimals" type="int" min="0" max="10" gui-text="Decimal tolerance" gui-description="The more decimals the more distinct layers you will get. This only applies for the sub layers (threshold > 1)">1</param>
     <param name="apply_transformations" type="bool" gui-text="Apply transformations (requires separate extension)" gui-description="This will call the extension 'Apply Transformations'. Helps avoiding geometry shifting">false</param>
     <param name="cleanup"  type="bool" gui-text="Cleanup all unused groups/layers (requires separate extension)" gui-description="This will call the extension 'Remove Empty Groups' if available">true</param>
-
+    <param name="put_unfiltered"  type="bool" gui-text="Put unfiltered elements to a separate layer">false</param>
-    <label>This extension will re-layer your selected items or the whole document according to their style (stroke or fill)</label>
+    <param name="show_info"  type="bool" gui-text="Show elements which have no style attributes to filter">false</param>
+	<spacer/>
+    <label>This extension will re-layer your selected items or the whole document according to their style values (stroke or fill).</label>
+    <label>The filtering applies only to style attribute of the elements. It does not filter for stroke or fill if they are set separately. You can use the separate 'Cleanup Styles' extension to migrate these separated attributes into style attribute.</label>
     <label>Tinkered by Mario Voigt / Stadtfabrikanten e.V. (2020)</label>
     <label appearance="url">https://fablabchemnitz.de</label>
     <effect>

extensions/fablabchemnitz/styles_to_layers.py

@@ -8,7 +8,7 @@ Features
 Author: Mario Voigt / FabLab Chemnitz
 Mail: mario.voigt@stadtfabrikanten.org
 Date: 19.08.2020
-Last patch: 05.04.2021
+Last patch: 11.04.2021
 License: GNU GPL v3
 """
 import inkex
@@ -40,23 +40,17 @@ class StylesToLayers(inkex.EffectExtension):
         return layer
         
     def __init__(self):
-        inkex.Effect.__init__(self)
+        inkex.EffectExtension.__init__(self)
         self.arg_parser.add_argument("--apply_transformations", type=inkex.Boolean, default=False, help="Run 'Apply Transformations' extension before running vpype. Helps avoiding geometry shifting")
         self.arg_parser.add_argument("--separateby", default = "stroke", help = "Separate by")
         self.arg_parser.add_argument("--parsecolors",default = "hexval", help = "Sort colors by")
         self.arg_parser.add_argument("--subdividethreshold", type=int, default = 1, help = "Threshold for splitting into sub layers")
         self.arg_parser.add_argument("--decimals", type=int, default = 1, help = "Decimal tolerance")
         self.arg_parser.add_argument("--cleanup", type=inkex.Boolean, default = True, help = "Decimal tolerance")
+        self.arg_parser.add_argument("--put_unfiltered", type=inkex.Boolean, default = False, help = "Put unfiltered elements to a separate layer")  
+        self.arg_parser.add_argument("--show_info", type=inkex.Boolean, default = False, help = "Show elements which have no style attributes to filter")
 
     def effect(self):
-        applyTransformAvailable = False # at first we apply external extension
-        try:
-            import applytransform
-            applyTransformAvailable = True
-        except Exception as e:
-            # inkex.utils.debug(e)
-            inkex.utils.debug("Calling 'Apply Transformations' extension failed. Maybe the extension is not installed. You can download it from official InkScape Gallery. Skipping ...")
-
     
         def colorsort(stroke_value): #this function applies to stroke or fill (hex colors)
             if self.options.parsecolors == "hexval":
@@ -69,6 +63,14 @@ class StylesToLayers(inkex.EffectExtension):
                 return float(Color(stroke_value).to_hsl()[2])
             return None
     
+        applyTransformAvailable = False # at first we apply external extension
+        try:
+            import applytransform
+            applyTransformAvailable = True
+        except Exception as e:
+            # inkex.utils.debug(e)
+            inkex.utils.debug("Calling 'Apply Transformations' extension failed. Maybe the extension is not installed. You can download it from official InkScape Gallery. Skipping ...")
+             
         layer_name = None
         layerNodeList = [] #list with layer, neutral_value, element and self.options.separateby type
         selected = [] #list of items to parse
@@ -80,8 +82,13 @@ class StylesToLayers(inkex.EffectExtension):
             selected = self.svg.selected.values()
 
         for element in selected:
+        
+            # additional option to apply transformations. As we clear up some groups to form new layers, we might lose translations, rotations, etc.
             if self.options.apply_transformations is True and applyTransformAvailable is True:
                 applytransform.ApplyTransform().recursiveFuseTransform(element) 
+        
+            if isinstance(element, inkex.ShapeElement): # Elements which have a visible representation on the canvas (even without a style attribute but by their type); if we do not use that ifInstance Filter we provokate unkown InkScape fatal crashes
+                           
                 style = element.get('style')
                 if style is not None:
                     #if no style attributes or stroke/fill are set as extra attribute
@@ -181,6 +188,17 @@ class StylesToLayers(inkex.EffectExtension):
                                 layerNodeList.append([self.createLayer(layerNodeList, layer_name), neutral_value, element, self.options.separateby])
                             else:
                                 layerNodeList.append([currentLayer, neutral_value, element, self.options.separateby]) #layer is existent. append items to this later
+                else: #if no style attribute in element and not a group
+                    if isinstance(element, inkex.Group) is False:
+                        if self.options.show_info:
+                            inkex.utils.debug(element.get('id') + ' has no style attribute')
+                        if self.options.put_unfiltered:
+                                layer_name = 'without-style-attribute'
+                                currentLayer = self.findLayer(layer_name)
+                                if currentLayer is None: #layer does not exist, so create a new one
+                                    layerNodeList.append([self.createLayer(layerNodeList, layer_name), None, element, None])
+                                else:
+                                    layerNodeList.append([currentLayer, None, element, None]) #layer is existent. append items to this later
 
         contentlength = 0 #some counter to track if there are layers inside or if it is just a list with empty children
         for layerNode in layerNodeList: