From 0c727dd16c3ddac29d01b3d269ec8d6b06c13066 Mon Sep 17 00:00:00 2001 From: peteruithoven Date: Mon, 31 Jul 2017 10:31:26 +0200 Subject: [PATCH 1/3] Disable public publish to npm --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 01f4e42..f58fe60 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,8 @@ "url": "git+https://github.com/Doodle3D/Doodle3D-Slicer.git" }, "author": "", - "license": "ISC", + "license": "UNLICENSED", + "private": true, "bugs": { "url": "https://github.com/Doodle3D/Doodle3D-Slicer/issues" }, From b566a387c6784c929ec535848304a0feba5d1d7c Mon Sep 17 00:00:00 2001 From: casperlamboo Date: Tue, 1 Aug 2017 13:58:29 +0200 Subject: [PATCH 2/3] remove parts that don't contain shells --- src/sliceActions/generateInnerLines.js | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/sliceActions/generateInnerLines.js b/src/sliceActions/generateInnerLines.js index 0c97a5d..22809e1 100644 --- a/src/sliceActions/generateInnerLines.js +++ b/src/sliceActions/generateInnerLines.js @@ -31,22 +31,24 @@ export default function generateInnerLines(slices, settings) { const outerLine = part.shape.offset(-nozzleRadius, offsetOptions); - if (outerLine.paths.length > 0) { - part.shell.push(outerLine); + if (outerLine.paths.length === 0) continue; - // start with 1 because outerLine is the 1st (0) shell - for (let inset = 1; inset < numShells; inset += 1) { - const offset = inset * nozzleDiameter; + part.shell.push(outerLine); - const shell = outerLine.offset(-offset, offsetOptions); + // start with 1 because outerLine is the 1st (0) shell + for (let inset = 1; inset < numShells; inset += 1) { + const offset = inset * nozzleDiameter; - if (shell.paths.length > 0) { - part.shell.push(shell); - } else { - break; - } + const shell = outerLine.offset(-offset, offsetOptions); + + if (shell.paths.length === 0) { + break; + } else { + part.shell.push(shell); } } } + + slice.parts.filter(part => !part.closed || part.shell.length !== 0); } } From 9363fe58af933e0998262982545384ad59388f00 Mon Sep 17 00:00:00 2001 From: casperlamboo Date: Tue, 1 Aug 2017 14:24:15 +0200 Subject: [PATCH 3/3] actually edit parts array --- src/sliceActions/generateInnerLines.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sliceActions/generateInnerLines.js b/src/sliceActions/generateInnerLines.js index 22809e1..04e981f 100644 --- a/src/sliceActions/generateInnerLines.js +++ b/src/sliceActions/generateInnerLines.js @@ -49,6 +49,6 @@ export default function generateInnerLines(slices, settings) { } } - slice.parts.filter(part => !part.closed || part.shell.length !== 0); + slice.parts = slice.parts.filter(part => !part.closed || part.shell.length !== 0); } }