diff --git a/docs-web/src/main/java/com/sismics/docs/rest/resource/RouteResource.java b/docs-web/src/main/java/com/sismics/docs/rest/resource/RouteResource.java index 30e71a63..f3320eab 100644 --- a/docs-web/src/main/java/com/sismics/docs/rest/resource/RouteResource.java +++ b/docs-web/src/main/java/com/sismics/docs/rest/resource/RouteResource.java @@ -209,7 +209,9 @@ public class RouteResource extends BaseResource { routeStepDao.endRouteStep(routeStepDto.getId(), routeStepTransition, comment, principal.getId()); RouteStepDto newRouteStep = routeStepDao.getCurrentStep(documentId); RoutingUtil.updateAcl(documentId, newRouteStep, routeStepDto, principal.getId()); - RoutingUtil.sendRouteStepEmail(documentId, routeStepDto); + if (newRouteStep != null) { + RoutingUtil.sendRouteStepEmail(documentId, newRouteStep); + } JsonObjectBuilder response = Json.createObjectBuilder() .add("readable", aclDao.checkPermission(documentId, PermType.READ, getTargetIdList(null))); diff --git a/docs-web/src/test/java/com/sismics/docs/rest/TestRouteResource.java b/docs-web/src/test/java/com/sismics/docs/rest/TestRouteResource.java index 082a4e69..e2e7478b 100644 --- a/docs-web/src/test/java/com/sismics/docs/rest/TestRouteResource.java +++ b/docs-web/src/test/java/com/sismics/docs/rest/TestRouteResource.java @@ -226,7 +226,7 @@ public class TestRouteResource extends BaseJerseyTest { .param("transition", "APPROVED")), JsonObject.class); Assert.assertFalse(json.containsKey("route_step")); Assert.assertTrue(json.getBoolean("readable")); // Admin can read everything - Assert.assertTrue(popEmail().contains("workflow step")); + Assert.assertNull(popEmail()); // Last step does not send any email // Get the route on document 1 json = target().path("/route")