A little less code duplication

This commit is contained in:
peteruithoven 2013-10-28 01:26:58 +01:00
parent 96a48b38d9
commit f783726c47
2 changed files with 20 additions and 17 deletions

View File

@ -310,16 +310,24 @@ function SettingsWindow() {
this.printerSelectorChanged = function(e) {
var selectedOption = self.printerSelector.find("option:selected");
switch(selectedOption.val()) {
if(self.isMarlinPrinter(selectedOption.val())) {
self.x3gSettings.hide();
self.gcodeSettings.show();
} else {
self.gcodeSettings.hide();
self.x3gSettings.show();
}
}
this.isMarlinPrinter = function(printer) {
switch(printer) {
case "makerbot_generic":
case "makerbot_replicator2":
case "makerbot_thingomatic":
self.gcodeSettings.hide();
self.x3gSettings.show();
return false;
break;
default:
self.x3gSettings.hide();
self.gcodeSettings.show();
return true;
break;
}
}

View File

@ -65,19 +65,14 @@ function generate_gcode() {
var startCode = "";
var endCode = "";
switch(printerType) {
case "makerbot_generic":
case "makerbot_replicator2":
case "makerbot_thingomatic":
startCode = settings["printer.startcode.x3g"];
endCode = settings["printer.endcode.x3g"];
break;
default:
startCode = settings["printer.startcode.marlin"];
endCode = settings["printer.endcode.marlin"];
break;
if(settingsWindow.isMarlinPrinter(printerType)) {
startCode = settings["printer.startcode.marlin"];
endCode = settings["printer.endcode.marlin"];
} else {
startCode = settings["printer.startcode.x3g"];
endCode = settings["printer.endcode.x3g"];
}
startCode = subsituteVariables(startCode,temperature,bedTemperature,preheatTemperature,preheatBedTemperature);
startCode = startCode.split("\n");