Compare commits

..

2 Commits

Author SHA1 Message Date
Falko Richter
0b1d14afe8 added a changelog 2024-07-15 22:04:43 +02:00
Falko Richter
61c9f68332 logging actor errors as errors 2024-07-15 21:39:48 +02:00
2 changed files with 10 additions and 3 deletions

View File

@ -1,4 +1,11 @@
# Revision history for Difluoroborane # Revision history for Difluoroborane
A changelog following the [keepachangelog.com/en/1.0.0](https://keepachangelog.com/en/1.0.0/) standard
## 0.4.3 -- unreleased
### CHANGED Changed
* errors in actors are now logged as errors ([#84](https://gitlab.com/fabinfra/fabaccess/bffh/-/issues/84))
## 0.4.1 -- 2022-04-24 ## 0.4.1 -- 2022-04-24

View File

@ -71,17 +71,17 @@ impl Actor for Process {
} }
} }
Ok(retv) => { Ok(retv) => {
tracing::warn!(%name, ?state, code=?retv.status, tracing::error!(%name, ?state, code=?retv.status,
"Actor returned nonzero exitcode" "Actor returned nonzero exitcode"
); );
if !retv.stderr.is_empty() { if !retv.stderr.is_empty() {
let errstr = String::from_utf8_lossy(&retv.stderr); let errstr = String::from_utf8_lossy(&retv.stderr);
for line in errstr.lines() { for line in errstr.lines() {
tracing::warn!(%name, %line, "actor stderr"); tracing::error!(%name, %line, "actor stderr");
} }
} }
} }
Err(error) => tracing::warn!(%name, ?error, "process actor failed to run cmd"), Err(error) => tracing::error!(%name, ?error, "process actor failed to run cmd"),
} }
}) })
} }