From 695dd71921e2bcaed24ca2a7789f3ec1b4aef991 Mon Sep 17 00:00:00 2001 From: Paulo Gustavo Veiga Date: Mon, 13 Dec 2021 14:00:47 -0800 Subject: [PATCH] Remove underscore from develop --- packages/mindplot/.eslintrc.json | 1 - packages/mindplot/package.json | 1 - packages/mindplot/webpack.playground.js | 1 - packages/web2d/.eslintrc.json | 1 - packages/web2d/src/components/peer/svg/TextPeer.js | 1 - 5 files changed, 5 deletions(-) diff --git a/packages/mindplot/.eslintrc.json b/packages/mindplot/.eslintrc.json index 25ad6994..f8aa3943 100644 --- a/packages/mindplot/.eslintrc.json +++ b/packages/mindplot/.eslintrc.json @@ -15,7 +15,6 @@ }, "plugins": ["only-warn"], "rules": { - "no-underscore-dangle": "off", "no-plusplus": "off", "class-methods-use-this": "off", "import/no-extraneous-dependencies": ["error", {"devDependencies": ["!cypress/**/*.js"]}] diff --git a/packages/mindplot/package.json b/packages/mindplot/package.json index a5321e17..0a877713 100644 --- a/packages/mindplot/package.json +++ b/packages/mindplot/package.json @@ -34,7 +34,6 @@ "@wisemapping/web2d": "^0.0.1", "jquery": "^3.6.0", "mootools": "1.4.5", - "underscore": "^1.13.1" }, "devDependencies": { "@babel/core": "^7.14.6", diff --git a/packages/mindplot/webpack.playground.js b/packages/mindplot/webpack.playground.js index 76399109..45150052 100644 --- a/packages/mindplot/webpack.playground.js +++ b/packages/mindplot/webpack.playground.js @@ -37,7 +37,6 @@ module.exports = { exclude: [ /node_modules/, path.resolve(__dirname, '../../libraries/mootools-core-1.4.5'), - path.resolve(__dirname, '../../libraries/underscore-min'), /lib\/raphael/ig, ], }, diff --git a/packages/web2d/.eslintrc.json b/packages/web2d/.eslintrc.json index f497c7bc..5bf8a6a8 100644 --- a/packages/web2d/.eslintrc.json +++ b/packages/web2d/.eslintrc.json @@ -11,7 +11,6 @@ "Class": "readonly" }, "rules": { - "no-underscore-dangle": "off", "no-restricted-syntax": "off", "no-plusplus": "off", "max-len": [1,250], diff --git a/packages/web2d/src/components/peer/svg/TextPeer.js b/packages/web2d/src/components/peer/svg/TextPeer.js index 62378b5c..0fa29b22 100644 --- a/packages/web2d/src/components/peer/svg/TextPeer.js +++ b/packages/web2d/src/components/peer/svg/TextPeer.js @@ -50,7 +50,6 @@ class TextPeer extends ElementPeer { if (text) { const lines = text.split('\n'); const me = this; - // FIXME: we could use underscorejs here lines.forEach((line) => { const tspan = window.document.createElementNS(ElementPeer.svgNamespace, 'tspan'); tspan.setAttribute('dy', '1em');