Fix NPE on recapcha validation

This commit is contained in:
Paulo Gustavo Veiga 2022-02-03 21:27:43 -08:00
parent 119eb03f53
commit c55025f07f
2 changed files with 7 additions and 5 deletions

View File

@ -102,7 +102,7 @@ public class UserController extends BaseController {
final String recaptcha = registration.getRecaptcha();
if (recaptcha != null) {
final String reCaptchaResponse = captchaService.verifyRecaptcha(remoteAddress, recaptcha);
if (!reCaptchaResponse.isEmpty()) {
if (reCaptchaResponse != null && !reCaptchaResponse.isEmpty()) {
errors.rejectValue("recaptcha", reCaptchaResponse);
}
} else {

View File

@ -6,6 +6,7 @@ import org.apache.http.NameValuePair;
import org.apache.http.client.fluent.Form;
import org.apache.http.client.fluent.Request;
import org.apache.log4j.Logger;
import org.jetbrains.annotations.Nullable;
import javax.validation.constraints.NotNull;
import java.io.IOException;
@ -23,6 +24,7 @@ public class RecaptchaService {
private final static ObjectMapper objectMapper = new ObjectMapper();
private String recaptchaSecret;
@Nullable
public String verifyRecaptcha(@NotNull String ip, @NotNull String recaptcha) {
final List<NameValuePair> build = Form.form()