From ea4684d9c890b8ac0cd4d0c4064390c8598e4ce9 Mon Sep 17 00:00:00 2001
From: Ezequiel Bergamaschi <ezequielbergamaschi@gmail.com>
Date: Tue, 11 Feb 2014 02:04:09 -0300
Subject: [PATCH] get label by id with user and validate label exists on link
 to mindmap

---
 .../java/com/wisemapping/dao/LabelManager.java |  2 +-
 .../com/wisemapping/dao/LabelManagerImpl.java  | 18 +++++++++++-------
 .../com/wisemapping/rest/LabelController.java  |  2 +-
 .../wisemapping/rest/MindmapController.java    | 15 +++++++++++++--
 .../com/wisemapping/service/LabelService.java  |  2 +-
 .../wisemapping/service/LabelServiceImpl.java  |  4 ++--
 6 files changed, 29 insertions(+), 14 deletions(-)

diff --git a/wise-webapp/src/main/java/com/wisemapping/dao/LabelManager.java b/wise-webapp/src/main/java/com/wisemapping/dao/LabelManager.java
index dae03436..7d0363dc 100644
--- a/wise-webapp/src/main/java/com/wisemapping/dao/LabelManager.java
+++ b/wise-webapp/src/main/java/com/wisemapping/dao/LabelManager.java
@@ -17,7 +17,7 @@ public interface LabelManager {
     List<Label> getAllLabels(@NotNull final User user);
 
     @Nullable
-    Label getLabelById(int id);
+    Label getLabelById(int id, @NotNull final User user);
 
     @Nullable
     Label getLabelByTitle(@NotNull final String title, @NotNull final User user);
diff --git a/wise-webapp/src/main/java/com/wisemapping/dao/LabelManagerImpl.java b/wise-webapp/src/main/java/com/wisemapping/dao/LabelManagerImpl.java
index 659be122..54ded25a 100644
--- a/wise-webapp/src/main/java/com/wisemapping/dao/LabelManagerImpl.java
+++ b/wise-webapp/src/main/java/com/wisemapping/dao/LabelManagerImpl.java
@@ -29,19 +29,16 @@ public class LabelManagerImpl extends HibernateDaoSupport
 
     @Nullable
     @Override
-    public Label getLabelById(int id) {
-        return getHibernateTemplate().get(Label.class, id);
+    public Label getLabelById(int id, @NotNull final User user) {
+        List<Label> labels = getHibernateTemplate().find("from com.wisemapping.model.Label wisemapping where id=? and creator=?", new Object[]{id, user});
+        return getFirst(labels);
     }
 
     @Nullable
     @Override
     public Label getLabelByTitle(@NotNull String title, @NotNull final User user) {
-        Label result = null;
         final List<Label> labels = getHibernateTemplate().find("from com.wisemapping.model.Label wisemapping where title=? and creator=?", new Object[]{title, user});
-        if (labels != null && !labels.isEmpty()) {
-            result = labels.get(0);
-        }
-        return result;
+        return getFirst(labels);
     }
 
     @Override
@@ -49,5 +46,12 @@ public class LabelManagerImpl extends HibernateDaoSupport
         getHibernateTemplate().delete(label);
     }
 
+    @Nullable private Label getFirst(List<Label> labels) {
+        Label result = null;
+        if (labels != null && !labels.isEmpty()) {
+            result = labels.get(0);
+        }
+        return result;
+    }
 
 }
diff --git a/wise-webapp/src/main/java/com/wisemapping/rest/LabelController.java b/wise-webapp/src/main/java/com/wisemapping/rest/LabelController.java
index a9293a69..be42dffa 100644
--- a/wise-webapp/src/main/java/com/wisemapping/rest/LabelController.java
+++ b/wise-webapp/src/main/java/com/wisemapping/rest/LabelController.java
@@ -69,7 +69,7 @@ public class LabelController extends BaseController {
     @ResponseStatus(value = HttpStatus.NO_CONTENT)
     public void deleteLabelById(@PathVariable int id) throws WiseMappingException {
         final User user = Utils.getUser();
-        final Label label = labelService.getLabelById(id);
+        final Label label = labelService.getLabelById(id, user);
         if (label == null) {
             throw new LabelCouldNotFoundException("Label could not be found. Id: " + id);
         }
diff --git a/wise-webapp/src/main/java/com/wisemapping/rest/MindmapController.java b/wise-webapp/src/main/java/com/wisemapping/rest/MindmapController.java
index 6cc0ea37..6302f064 100644
--- a/wise-webapp/src/main/java/com/wisemapping/rest/MindmapController.java
+++ b/wise-webapp/src/main/java/com/wisemapping/rest/MindmapController.java
@@ -20,6 +20,7 @@ package com.wisemapping.rest;
 
 import com.mangofactory.swagger.annotations.ApiIgnore;
 import com.wisemapping.exceptions.ImportUnexpectedException;
+import com.wisemapping.exceptions.LabelCouldNotFoundException;
 import com.wisemapping.exceptions.MapCouldNotFoundException;
 import com.wisemapping.exceptions.MultipleSessionsOpenException;
 import com.wisemapping.exceptions.SessionExpiredException;
@@ -45,6 +46,7 @@ import com.wisemapping.rest.model.RestMindmapInfo;
 import com.wisemapping.rest.model.RestMindmapList;
 import com.wisemapping.security.Utils;
 import com.wisemapping.service.CollaborationException;
+import com.wisemapping.service.LabelService;
 import com.wisemapping.service.LockInfo;
 import com.wisemapping.service.LockManager;
 import com.wisemapping.service.MindmapService;
@@ -88,6 +90,10 @@ public class MindmapController extends BaseController {
     @Autowired
     private MindmapService mindmapService;
 
+    @Qualifier("labelService")
+    @Autowired
+    private LabelService labelService;
+
     @RequestMapping(method = RequestMethod.GET, value = "/maps/{id}", produces = {"application/json", "application/xml", "text/html"})
     @ResponseBody
     public RestMindmap retrieve(@PathVariable int id) throws WiseMappingException {
@@ -634,13 +640,18 @@ public class MindmapController extends BaseController {
     @ResponseStatus(value = HttpStatus.OK)
     public void addLabel(@RequestBody RestLabel restLabel, @RequestParam(required = true) String ids) throws WiseMappingException {
         int labelId = restLabel.getId();
+        final User user = Utils.getUser();
+        final Label delegated = restLabel.getDelegated();
+        delegated.setCreator(user);
+        final Label found = labelService.getLabelById(labelId, user);
+        if (found == null) {
+            throw new LabelCouldNotFoundException("Label could not be found. Id: " + labelId);
+        }
         for (String id : ids.split(",")) {
             final int mindmapId = Integer.parseInt(id);
             final Mindmap mindmap = findMindmapById(mindmapId);
             final Label label = mindmap.findLabel(labelId);
             if (label == null) {
-                final Label delegated = restLabel.getDelegated();
-                delegated.setCreator(Utils.getUser());
                 mindmapService.addLabel(mindmap, delegated);
             }
         }
diff --git a/wise-webapp/src/main/java/com/wisemapping/service/LabelService.java b/wise-webapp/src/main/java/com/wisemapping/service/LabelService.java
index 0e44a7f1..097987d8 100644
--- a/wise-webapp/src/main/java/com/wisemapping/service/LabelService.java
+++ b/wise-webapp/src/main/java/com/wisemapping/service/LabelService.java
@@ -15,7 +15,7 @@ public interface LabelService {
     @NotNull List<Label> getAll(@NotNull final User user);
 
     @Nullable
-    Label getLabelById(int id);
+    Label getLabelById(int id, @NotNull final User user);
 
     public Label getLabelByTitle(@NotNull String title, @NotNull final User user);
 
diff --git a/wise-webapp/src/main/java/com/wisemapping/service/LabelServiceImpl.java b/wise-webapp/src/main/java/com/wisemapping/service/LabelServiceImpl.java
index cfb227d5..531eaf5f 100644
--- a/wise-webapp/src/main/java/com/wisemapping/service/LabelServiceImpl.java
+++ b/wise-webapp/src/main/java/com/wisemapping/service/LabelServiceImpl.java
@@ -31,8 +31,8 @@ public class LabelServiceImpl implements LabelService {
     }
 
     @Override @Nullable
-    public Label getLabelById(int id) {
-        return labelManager.getLabelById(id);
+    public Label getLabelById(int id, @NotNull final User user) {
+        return labelManager.getLabelById(id, user);
     }
 
     @Nullable